Updated readme to show mini-css-extract plugin#142
Closed
nergmada wants to merge 1 commit intosveltejs:masterfrom
Closed
Updated readme to show mini-css-extract plugin#142nergmada wants to merge 1 commit intosveltejs:masterfrom
nergmada wants to merge 1 commit intosveltejs:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
I think we should rebase and merge this changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the readme to reflect the issue raised in #95. Essentially, the ExtractText plugin has become abandonware and should be replaced with mini-css-extract.
I've also added a small paragraph regarding multiple entrypoints and a warning about sideeffects. This isn't strictly a svelte-loader issue but is an obscure issue on mini-css-extract plugin's readme, so I thought it best to highlight it here. If you disagree I'll happily re-edit this to exclude it.